search

Lewiscowles1986 / WordPressSVGPlugin

WordPress SVG Plugin
GNU General Public License v3.0
42 stars 4 forks source link

Prevent oversized emojis #16

Closed cfxd closed 7 years ago

cfxd commented 7 years ago

Prevent oversized emojis in admin like this...

image

cfxd commented 7 years ago

Man, I didn't even notice those until you pointed them out. My IDE automatically removed those white spaces.

Is there a particular reason you want to keep them? Want them removed as another PR? I could also just change the issue/commit msg to include white space removal...

Lewiscowles1986 commented 7 years ago

I did create the issue for you. Is there some way you can edit the commit using a text-editor (it's a one-file edit, notepad, gedit or any text editor should allow without meddling too much).

I'd also prefer not to have a PR for whitespace removal :rofl:

cfxd commented 7 years ago

Yeah no problem, I just rebased removing the whitespace removal. Any particular reason you want to keep the whitespace?

Lewiscowles1986 commented 7 years ago

The main reason is that everyone could make changes based upon preference, or IDE config, leading to making merge conflicts harder to resolve (we're looking at lines we don't need to look at).

Thank you for being awesome btw :wink:

cfxd commented 7 years ago

Thanks :)

The white space really should be removed.