search

Lewiscowles1986 / WordPressSVGPlugin

WordPress SVG Plugin
GNU General Public License v3.0
42 stars 4 forks source link

Separate repo? #8

Open Lewiscowles1986 opened 7 years ago

Lewiscowles1986 commented 7 years ago

Should this be moved to a separate org (I'm thinking moving to my business org)?

dmhendricks commented 6 years ago

Feedback:

  1. You might also consider a more Composer-friendly slug, since more and more people are using Composer to manage WordPress. Something like "codesign2/wp-enable-svg" or "codesign2/enable-svg-uploads" whatever (neither of those appear to be currently in use on the wp.org repo, either).
  2. I would make the slug match the plugin directory name.
  3. It seems that most WP plugins put the files in the Git root rather than wp-content/plugins/plugin-slug. I think (?) this is also required in order to properly work with GitHub Updater, yes?
Lewiscowles1986 commented 6 years ago

I've never used the github updater, but I'd appreciate PR's (preferably with issues) against each individual point here. Even just issues raised so I can gauge user-input before PR'ing or accepting PR's then I'd be grateful.

dmhendricks commented 6 years ago

(also, though it will have no impact on function, it's not typical in WP to name the main plugin file index.php. Generally, they are named something like my-plugin-name/my-plugin-name.php or enable-svg-uploads/enable-svg.php, purely as examples.)