Lewiscowles1986 / filesystem-file-extension-php

PHP File Extension Utility Library
GNU General Public License v3.0
1 stars 2 forks source link

Composer dev install fails if missing ext-debug #7

Open Lewiscowles1986 opened 6 years ago

Lewiscowles1986 commented 6 years ago

Travis allowed failure for php-nightly fails due to missing ext-debug

  Problem 1
    - The requested PHP extension ext-xdebug * is missing from your system. Install or enable PHP's xdebug extension.

Related to #4 #5 #6

peter279k commented 5 years ago

The php-nightly test will always be failed about the ext-xdebug issue because of internal Travis CI problem.

Please look at this issue.

Lewiscowles1986 commented 5 years ago

Alternative documentation (from issue) http://docs.travis-ci.com/user/languages/php/#PHP-nightly-builds seems to suggest it could be built with the right pecl command

I think it's less that Travis is limited, and more that it takes time for xDebug team to catch up. 7.3 works with xDebug now, so if someone wants a bleeding edge fork of this they should know enough to comment it out. For everyone else it's guard-rails.

peter279k commented 5 years ago

@Lewiscowles1986, I think it's possible to install xdebug extension.

I will try this and create another PR about this πŸ‘.

peter279k commented 5 years ago

@Lewiscowles1986, finally I tried to use the pecl install xdebug when php-nightly test in Travis CI build.

But it looks like the official xdebug doesn't support the xdebug extension for php-nightly build.

The detailed Travis CI build log is available here.

The error message when pecl install xdebug is as follows:

checking Check for supported PHP versions... configure: error: not supported. Need a PHP version >= 7.0.0 and < 7.3.0 (found 7.4.0-dev)
ERROR: `/tmp/pear/install/xdebug/configure --with-php-config=/home/travis/.phpenv/versions/master/bin/php-config' failed

And I think the xdebug should only support the stable PHP version.

Lewiscowles1986 commented 5 years ago

@peter279k I believe the following two lines may do the trick to having nightly work

pecl install -f xdebug-beta
php-ext-enable xdebug

the first line is changing

if [[ $TRAVIS_PHP_VERSION = nightly* ]]; then pecl install xdebug; fi

to

if [[ $TRAVIS_PHP_VERSION = nightly* ]]; then pecl install xdebug-beta; fi

Although maybe there are more pecl distributions or maybe waiting for

https://travis-ci.org/Lewiscowles1986/filesystem-file-extension-php/jobs/487103097

to track when xdebug-beta runs (at present even beta is locked to 7.3)

Lewiscowles1986 commented 5 years ago

Let's track https://pecl.php.net/package-changelog.php?package=xdebug for 7.4.x

peter279k commented 5 years ago

@Lewiscowles1986, thank you for your reply.

Let me check this and test on Travis CI build again.

peter279k commented 5 years ago

Let's track https://pecl.php.net/package-changelog.php?package=xdebug for 7.4.x

It looks like the xdebug-beta doesn't support the php-7.4-dev.

If possible, we can ask the XDebug team about how to install the xdebug-beta on php-7.4-dev.

peter279k commented 5 years ago

Finally I got the answer from the creator of XDebug, @derickr.

No, it is not. PHP 7.4 has introduced some changes internally that stop Xdebug from compiling. I am tracking this in https://bugs.xdebug.org/view.php?id=1599

cheers, Derick

Lewiscowles1986 commented 5 years ago

@peter279k all of that apart from bothering xdebug creator is in the above messages, please read them fully and follow any links. Instead of emailing and questioning xdebug creator, Lets track the URL given in https://github.com/Lewiscowles1986/filesystem-file-extension-php/issues/7#issuecomment-459483122 until changelog reports supporting PHP7.4

peter279k commented 5 years ago

Thank you for your reply.

Alright. It's my fault and just track the status via comment #7 until the beta XDebug supports the PHP 7.4 dev.

Lewis Cowles notifications@github.com ζ–Ό 2019εΉ΄2月2ζ—₯ ι€±ε…­ δΈ‹εˆ3:26ε―«ι“οΌš

@peter279k https://github.com/peter279k all of that apart from bothering xdebug creator is in the above messages, please read them fully and follow any links. Instead of emailing and questioning xdebug creator, Lets track the URL given in #7 (comment) https://github.com/Lewiscowles1986/filesystem-file-extension-php/issues/7#issuecomment-459483122 until changelog reports supporting PHP7.4

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Lewiscowles1986/filesystem-file-extension-php/issues/7#issuecomment-459943455, or mute the thread https://github.com/notifications/unsubscribe-auth/AImpM37DZFEKfC0MrMiDVkXRirkwf55Qks5vJT27gaJpZM4TjSL8 .

peter279k commented 4 years ago

@Lewiscowles1986, it's about one year for fighting for Travis CI build.

It's not resolved completely and the GitHub Workflow has been released now.

Do you have the plan to switch Travis CI to GitHub Workflow :)?

Lewiscowles1986 commented 4 years ago

I spoke with XDebug author and they said it fully supports 7.4.

I quite like having multiple build systems right now, but that doesn't mean I'm against work on GitHub actions either. At the end of the day, even if I disable it running or run it on a schedule and merges to master, it's another place to verify build integrity and correctness, another opportunity for people to learn.

Were you thinking of a PR?

peter279k commented 4 years ago

@Lewiscowles1986, thanks for your reply.

Let me have the try on Travis CI build and make related PR :).

Lewiscowles1986 commented 4 years ago

Thanks for assist on PR merging πŸ˜‰

I'm going to see if I can leave this open but freeze it as it should not have been the place to discuss 7.4