search

Leworoe / thunderbird-outlook-appointment

Get the hidden appointment from an email from outlook/teams as a .ics-file
https://addons.thunderbird.net/de/thunderbird/addon/outlook-teams-appointments/
MIT License
14 stars 3 forks source link

Swapped dark/light button icons fixed #2

Closed igorakkerman closed 2 years ago

Leworoe commented 2 years ago

Do you have any idea, why the icon on the dark theme isn´t right? The icon should be white. Everything should be fine with your commit, I´ve also looked in the docu, but I have no clue why this isn´t work. image

igorakkerman commented 2 years ago

The docomentation on https://webextension-api.thunderbird.net/en/91/messageDisplayAction.html#messagedisplayaction-themeicons says that dark refers to dark text with a light theme and light refers to light text with a dark theme. Indeed a bit confusing.

Leworoe commented 2 years ago

My problem is that the light icon is never used. I have loaded your branch in my thunderbird and tested it.

Light (good): image Dark (bad): image

I want to understand why the light icon is never used.

igorakkerman commented 2 years ago

I understand your question now, sorry for the confusion. I believe, the light parts of the PNG are actually transparent, which is why you don't see anything on a dark background. They should be made white instead.

Leworoe commented 2 years ago

I found a solution for this problem, I will detecting the theme in the js and change the icon from there.