Closed gasilva closed 4 years ago
Hi I tried to run the pull request and does not generate the same graphs for me. taking a quick look into the code it seems there are a lot of changes on the SIR part. M guess is it would be easier to break those on different requests so if we need to pull back or test we can see what is to be changed
I like ht enew look of the graph with titles
OK I will try
any news? @bolinches
Hi @gasilva. Thank you for sending the PR. But there seems to be another PR. Which one is the correct one? Could you close the unnecessary one?
Closed. Guilherme A. Lima da Silva,Dr.
On Sat, Apr 4, 2020 10:02 AM, Kai Sasaki notifications@github.com wrote:
Hi @gasilva. Thank you for sending the PR. But there seems to be another PR. Which one is the correct one? Could you close the unnecessary one?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
@Lewuathe can I get the code for generating the graph
@Lewuathe can I get the code for generating the graph
Yes. Sure. I think you asked to have one modification at time. I am just waiting.
Thanks btw! I figured out the code by making slight modifications. The code is now successfully generating the graph.
On Sat, 11 Apr, 2020, 3:34 AM Guilherme A. L. da Silva, < notifications@github.com> wrote:
@Lewuathe https://github.com/Lewuathe can I get the code for generating the graph
Yes. Sure. I think you asked to have one modification at time. I am just waiting.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Lewuathe/COVID19-SIR/pull/22#issuecomment-612238300, or unsubscribe https://github.com/notifications/unsubscribe-auth/APDBSWRWYHNB2RSX7BOK753RL6JVRANCNFSM4LZYSKTQ .
@gasilva Thanks for the PR. I confirmed it works properly too. LGTM.
@itsisthatis Thanks for checking in advance!
A new try for pulling the changes Please see files changed in the menu above.