search

LexManos / YUNoMakeGoodMap

Void map mod for Minecraft, simple as crap don't complain to me!
Apache License 2.0
10 stars 12 forks source link

Fire PopulateChunkEvent Pre and Post in ChunkProviders. #13

Closed Ivorforce closed 9 years ago

Ivorforce commented 9 years ago

This makes the void world types fire Forge's PopulateChunkEvent Pre and Post.

This is important because some mods may want to decide to generate entities or structures, beyond the wiped terrain, in void worlds, during chunk population.

LexManos commented 9 years ago

The point of this mod is to not let them. Because that's the point of a void world THERE IS NOTHING.

Ivorforce commented 9 years ago

There is a spawn island. People using my mod would like to replace said spawn island with their own.

That is a decision to be made by the mod, not by the Chunk Provider. If mods still generate in void worlds, in contradiction to the user's preferences, then those mods are at fault.

LexManos commented 9 years ago

Yes but there is no such thing as a void world, people just check if they are getting the call and generate shit. You can replace the spawn island with others in this. I had intended to sit down and support the schematic format but I found it to be so annoying to implement and so limited, that I didn't bother. THAT PR would be feasible.

Ivorforce commented 9 years ago

The .schematic format doesn't support modded blocks and items, and is thus relatively useless for most mod's purposes.

The 'there is no such thing as a void world' issue would be fixed by https://github.com/MinecraftForge/MinecraftForge/pull/1671, which is part of the reason I made that PR too.

LexManos commented 9 years ago

Blame XComp for that PR its 100% his job because hes the Dimensions Guru. Either way as it is there is no such thing as void world so if I were to do this it would defeat the purpose of the mod because you'd have random shit from mods generating.

As for the schematic format being crap/lacking. Yes I know. Which as i said is why it's never been implemented. {It falls under the annoying category} Whoever is in charge of that should REALLY update It to the modern times. ID maps, named items, and the like.

But from the sounds of it 1.9 is coming with an official replacement for the schematics files that isn't written poorly 4 years ago so we'll see what happens then.