LexiFi / gen_js_api

Easy OCaml bindings for Javascript libraries
MIT License
177 stars 31 forks source link

Stop using OMP directly #149

Closed mlasson closed 3 years ago

mlasson commented 3 years ago

Description

Let's stop using OMP directly and use the more idiomatic interfaces of Ppxlib. This allows to drop the conflict with newer version of OMP.

nojb commented 3 years ago

There is a lot of whitespace in the diff -- is this somehow related to the switch to ppxlib ?

mlasson commented 3 years ago

No that's the reindent commit. Please ignore whitespaces while reviewing !

mlasson commented 3 years ago

Ok, Ok, I'll remove the commit and I'll push it after merging.

hhugo commented 3 years ago

You should be able to remove the ref mark_as_handled_manually. It was introduced when adding compatibility with ppxlib while leaving the ppx free of a ppxlib dep.

mlasson commented 3 years ago

You should be able to remove the ref mark_as_handled_manually. It was introduced when adding compatibility with ppxlib while leaving the ppx free of a ppxlib dep.

Thanks for the remark !

nojb commented 3 years ago

Just to confirm, the gen_js_api binary can still be used to generate an implementation from an interface as before?

mlasson commented 3 years ago

Just to confirm, the gen_js_api binary can still be used to generate an implementation from an interface as before?

Yes !

rgrinberg commented 3 years ago

This is awesome @mlasson. Is there a release pending?

mlasson commented 3 years ago

This is awesome @mlasson. Is there a release pending?

I'll trigger one next week.