Closed mlasson closed 3 years ago
There is a lot of whitespace in the diff -- is this somehow related to the switch to ppxlib ?
No that's the reindent commit. Please ignore whitespaces while reviewing !
Ok, Ok, I'll remove the commit and I'll push it after merging.
You should be able to remove the ref mark_as_handled_manually
. It was introduced when adding compatibility with ppxlib while leaving the ppx free of a ppxlib dep.
You should be able to remove the ref mark_as_handled_manually. It was introduced when adding compatibility with ppxlib while leaving the ppx free of a ppxlib dep.
Thanks for the remark !
Just to confirm, the gen_js_api
binary can still be used to generate an implementation from an interface as before?
Just to confirm, the gen_js_api binary can still be used to generate an implementation from an interface as before?
Yes !
This is awesome @mlasson. Is there a release pending?
This is awesome @mlasson. Is there a release pending?
I'll trigger one next week.
Description
Let's stop using OMP directly and use the more idiomatic interfaces of Ppxlib. This allows to drop the conflict with newer version of OMP.