Support tuple on @js.scope

LexiFi / gen_js_api

Easy OCaml bindings for Javascript libraries

MIT License

177 stars 31 forks source link

Closed cannorin closed 2 years ago

cannorin commented 2 years ago

Related: #160

This PR makes @js.scope accept a tuple payload, which can be used to write a nested scope.

The example from #160 now can be written as:

module PlacesService: sig
type t
val new_places_service: Map.t -> t [@@js.new]
...
end
[@js.scope ("google", "maps", "places")]

Custom global object is also supported: assume fs: require('fs'), then we can now write
```
[@@@js.scope (Imports.fs, "promises")]
```

alainfrisch commented 2 years ago

This feature is not completely discoverable :-) Is there a natural place in the doc where it could be mentioned?

mlasson commented 2 years ago