Add bindings for WebSockets

LexiFi / ocaml-vdom

Elm architecture and (V)DOM for OCaml

MIT License

197 stars 13 forks source link

Add bindings for WebSockets #21

Closed leviroth closed 6 years ago

leviroth commented 6 years ago

This PR adds bindings for WebSockets.

One thing that's missing is support for CloseEvent, which adds a code attribute to the normal attributes of an event. I wasn't sure if there's an easy way to include the interface for Event.

copy commented 6 years ago

A few things that are missing from this PR:

t_of_js and t_to_js (so one can convert Event.target back to WebSocket.t)
The binaryType property
The readyState property and corresponding constants

leviroth commented 6 years ago

Added. Will squash once the jsoo bug is fixed.

copy commented 6 years ago

@leviroth Thanks! binaryType should also be settable, the rest looks good to me.

leviroth commented 6 years ago

I've squashed this down to one commit.

alainfrisch commented 6 years ago

Thanks!