search

LexiFi / ocaml-vdom

Elm architecture and (V)DOM for OCaml
MIT License
197 stars 13 forks source link

switch to dune build? #27

Closed joprice closed 4 years ago

joprice commented 4 years ago

I tried building this project with nix, and found that while this project doesn't use dune, it's dependency gen_js_api does. I was able to build it by switching from buildDunePackage to stdenv.mkDerivation and using make and make install for the build and install steps, but it would be nice to have uniformity there, since most opam projects are using dune nowadays. I was going to try to do a pr to add dune but I saw that gen_js_api uses dune, and assumed that this project has a good reason not to use it.

alainfrisch commented 4 years ago

No, it's just that we (LexiFi) don't use dune internally yet. Feel free to contribute a dune file in a PR if you wish.

alainfrisch commented 4 years ago

Wish granted!