Lexie-DelViscio / IRLCommunityEcosystemFunction

0 stars 0 forks source link

Patrick Sydow Peer Code Review 4/5/2022 #3

Open sydowpw opened 2 years ago

sydowpw commented 2 years ago

layout: page title: Code Review

General Review Checklist

Purpose

Yes, to test effect of suspension feeder diversity on algal blooms.

The names of the files are clear but it would be helpful to write a sentence for each file in the README.Rmd

Not quite, again just adding a sentence or two for each file would help.

Not always. I really appreciate the captions below plots but quick notes on what is going on to make those plots would help a lot to describe how to replicate them.

8

Within the README file, note which scripts aim to answer each goal and work towards an objective and which present results.

Organization

Not yet, but I definitely can see how it will fall into place.

A bit of time. Again, just supplying a comment or two on the purpose of each file would really help.

Well defined. Obvious # comments to note chunks. Within .Rmd files, code chucks are spaced with comments inbetween.

Organize files in scripts, data, and figs folders and also supply a 'road map' of sorts within the README file.

Functionality

Yes, meaningful creation of figures and relevant analysis.

All but the beginning! Working with the .xlsx files in the beginning is super hard. Most other portions work but I was also having trouble with priceTools package but from what I can tell this is not crucial to the project and there is more info in the repo on how to handle it.

Converting .xlsx sheets into individual .csv files would really help with running analyses. If data is modified to do analysis, you can also create a separate script for just modification and write a new modified data file to be used in another analysis script.

Specific File Comments