gbl
commented
3 months ago I just learned that, according to WOWHead, Righteous Fury is a 30 minute buff (https://www.wowhead.com/classic/spell=25780/righteous-fury#screenshots). On Turtle however, it lasts until cancelled.
So I changed, in the various localization.xx.lua files, the SMARTBUFF_PALADIN[1] row to have a -1 instead of 30. This fixes the problem.
Let me know if you want a pull request.
On my Paladin, Righteous Fury doesn't buff like intended. If I tell SmartBuff to have it on (I'm tanking 99% of the time so I always want it on, and not forget to rebuff after I die), it'll just turn Righteous Fury on, then off, then on, then off again, with each turn of the mouse wheel. And I get alternating messages "Character needs RF" and "Character Rebuff RF: 0 sec left".
I assume this could be because RF has no duration, which might be coded as 0, which might make SmartBuff think "it's running out" and want to rebuff. With the rebuff turning it off as the spell is a toggle. I tried setting the duration slider to 0, 30, or max, though, without that fixing the problem.