Leximon / Fluidlogged

Allows waterlogging for any fluid such as lava
https://modrinth.com/mod/fluidlogged
MIT License
7 stars 1 forks source link

Split this mod into API and content #29

Open ExpensiveKoala opened 1 month ago

ExpensiveKoala commented 1 month ago

Could you consider splitting this mod into the API which enables the fluid logging and permeability and another mod that acts as the official "Addon" that adds the fluid permeability, fluidloggable, etc... Additionally, adding the ability to use the API to only enable fluidlogging only for specific fluids (whitelisted).

These changes would allow other mod developers (like me) to use your mod as an API to easily add fluidlogging to any custom fluids without creating a dependency that would completely change how the game functions while maintaining a high degree of compatibility with fluid permeability etc.. if the "content" version of this mod is installed.

Leximon commented 1 month ago

Great idea

You may have noticed that I haven't worked on this mod for a really long time but your suggestion actually motivated me to continue this mod and it's a good opportunity to actually add comments (I regretted it) to all those mixins.

Thanks a lot 👍

The mod is really messy in my opinion and separating it should help.