Lexpedite / blawx

A user-friendly web-based tool for Rules as Code.

MIT License

105 stars 9 forks source link

Switch to most recent npm package for blockly install #290

Closed Gauntlet173 closed 1 year ago

Gauntlet173 commented 2 years ago

We had a problem in blockly 8.0.4 where the block messages were not loading properly. Solving that problem meant reverting to 8.0.2 in the Dockerfile, and manually importing version 8.0.4's messages file, and manually loading it after blockly.

Details on the fix are here.

We will need to check and see if this is no longer required. When it is no longer required, we will need to:

Modify Dockerfile to load the current version of Blockly
Modify blawx.html and test.html to load the version of en.js that comes with Blockly.

The issue is here, and a pull request that was supposed to fix the problem (but so far doesn't?) in blockly-v8.0.4-beta.1 is available here.

Will need to follow up on this whenever blockly releases a patch that claims to make a difference.

Gauntlet173 commented 2 years ago

Reviewed today, there does not seem to be any progress on Blockly's end. Moving this to next week to check again.

Gauntlet173 commented 2 years ago

There have been two patches since last I looked at this, either might help. The patch notes for 8.0.5 may have some information about other things that I should change about how I'm using the Blockly library. Check that out.

Gauntlet173 commented 2 years ago

https://github.com/google/blockly/pull/6329 seems targetted at this problem. Should be able to create a branch that just makes the required changes.

Gauntlet173 commented 2 years ago

Fixes the problem that we were having as long as we are using --branch develop. We could continue using git clone, and remove the --branch parameter in the Dockerfile once the master repository is at 8.0.5.

Probably better to switch to using the "latest" npm package, which is already currently 8.0.5. I just don't know if it will take some fixes in the templates, too.

Gauntlet173 commented 2 years ago

There is a branch with most of the required changes, revert_blockly_version_fix. The npm install should be fixed there, and merged with main.

Gauntlet173 commented 2 years ago

365 has resolved the versioning problem by using the develop branch at github. We can use NPM instead, but it will only have an impact on the initial install for the development environment. Setting as cleanup. Not urgent.