Leyart / aseprite

Automatically exported from code.google.com/p/aseprite
0 stars 0 forks source link

Context Bar Eats Hotkey Input #352

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
Case 1:

1. Have pencil tool selected.
2. Click the Pixel-perfect checkbox
3. Press space, and try to pan the canvas.

Case 2: 

1. Have pencil tool selected.
2. Click and drag the set brush size bar to set a brush size.
3. Press q to attempt to select the lasso tool, or press 2 to attempt to zoom 
on the canvas.

What is the expected output? What do you see instead?
For case 1, I think it's probably safe to have that checkbox never accept 
keyboard input since it's just on/off and solely clicking to give it keyboard 
focus means the user has already changed the option and probably wouldn't need 
to change it back with a key press.

For case 2... how about if I click (and release) any bar that accepts number 
input, it clears the field. (Because if there's already something there, and I 
type... pretty much any number it will end up as 32 and then I have to 
backspace anyway.) Spacebar and potentially any other non number hotkey should 
make it lose focus. If I have typed nothing before this happens, the brush size 
will go back to what it was. 

If I click (don't hold), the number field, then click the bar that sets the 
brush size the number input bar should similarly lose focus.

If I click and hold, then drag to set the brush size, the number bar should 
immediately lose focus. (because like case 1, one would figure I have already 
made the change I wanted from the mouse input given.)

What version of the product are you using? On what operating system?
Version-0.9.6-beta3 on Windows Vista 32bit

*Please provide any additional information below. If the program crashed on
Windows, you can attach the aseprite-memory.dmp file generated in the same
location where aseprite.exe is.*

Original issue reported on code.google.com by kirby...@gmail.com on 24 Feb 2014 at 10:17

GoogleCodeExporter commented 9 years ago
Related enough to put here. A lot of times I tried to draw, and no marks were 
made because my opacity was 0. I wondered how it kept getting set to 0. I 
figured it out, it's because just moving the mouse over any number input dialog 
gives it focus. So if my mouse drifted over opacity and I pressed space to pan, 
opacity got set to 0.

Original comment by kirby...@gmail.com on 1 Mar 2014 at 10:31

GoogleCodeExporter commented 9 years ago

Original comment by davidcapello on 3 Mar 2014 at 3:13

GoogleCodeExporter commented 9 years ago
Fixed in some way. Commit: 
https://github.com/aseprite/aseprite/commit/f107dd3cbca231530eb7040aa050302e7da4
132d

Changes:
* Check-boxes in context bar don't capture keyboard focus.
* About number fields 1) they lost focus after the slider is closed, 2) they 
don't get keyboard focus automatically on mouse over, 3) we have to click the 
field to focus it, 4) when we click the field the whole text is selected, so we 
can insert a new number, 5) only numbers are accepted in the field (other keys 
are propagated to parents, e.g. like spacebar)

Original comment by davidcapello on 8 Mar 2014 at 11:43