Leymooo / ItemFixer

Избавь свой сервер от читерских предметов!
http://rubukkit.org/threads/119485/
4 stars 8 forks source link

bug? [1.12.2] #19

Closed JoeSGT closed 6 years ago

JoeSGT commented 6 years ago

Hello i have paperspigot and it seem players with hacked items they are getting kicked to the hub i had check the console logs but there no errors can you please make a fix thanks

Leymooo commented 6 years ago

Try enable debug in spigot.yml and in server.properties

JoeSGT commented 6 years ago

i got no debugs errors or in game messages, console message

Leymooo commented 6 years ago

Do you know how to create this item?

JoeSGT commented 6 years ago

Here how i did it i made a PaperSpigot server and then i used this hacked client https://skillclient.com/index.html and went into creative and they is a next page in creative a tab called exploits it any items in that can cause you to get kick off of the server when you log back you are fine I installed the Forge side of the hacked client

Leymooo commented 6 years ago

I will test it later. Maybe there is error in bungeecord log?

JoeSGT commented 6 years ago

https://pastebin.com/S0qq7UtV yes there is the log from bungeecord it seem it's an issue with bungeecord

Leymooo commented 6 years ago

Hello! I am tested it. My setup:

Result: I can't reproduce. https://youtu.be/Tjt6_qwWpHw

JoeSGT commented 6 years ago

Did you use paperspigot?

Leymooo commented 6 years ago

Yes. I forgot to write it. Sorry. Build is 1300

JoeSGT commented 6 years ago

i used this bungeecord https://github.com/HexagonMC/BungeeCord

Leymooo commented 6 years ago

Do you have this error without itemfixer?

JoeSGT commented 6 years ago

No i do not have this error when i remove itemfixer, made a clean test server and manage to kick myself using the hacked client under the bungeecord i mention

JoeSGT commented 6 years ago

Here is my Bungeecord plugin list SchematicaPlugin-1.8-1.1.0.2-bungeecord.jar PlayerTabComplete.jar DeluxeChat-1.4.9.1.jar BungeePluginManager.jar

Leymooo commented 6 years ago

Can you try without plugins? I really dont know how to fix this. You can try to create issue on HexaCord repo. If they cant fix it, i will try to find what is going wrong.

JoeSGT commented 6 years ago

Sorry it took so long for me to fully debug this but i had found the exact issue, it's not bungeccord issue it seem to be a plugin compatible issue with ItemFixer and ProtocolLib and LibsDisguises '(issue with itemfixer)' i have LibsDisguise 9.5.0-SNAPSHOT here is the build number i used https://ci.md-5.net/job/LibsDisguises/186/ once you place it in your plugin folder and load it up take the item from hacked client make sure you have no bypass permission from itemfixer and boom you get kicked off of the server

Leymooo commented 6 years ago

Hi. On my survival server i have a 181 LibsDisguises build, i will try updaete it later. Can you try test only with PL, IF and LD and hexacord?

Leymooo commented 6 years ago

Okey. I can reproduce this. My setup: latest paperspigot with pl,if and ld. And original bungeecord without plugins.

Leymooo commented 6 years ago

https://github.com/Dimatert9/ItemFixer/blob/master/src/ru/leymooo/fixer/NBTListener.java#L54 this line causes this issue. Its like that i try to update player inventory and LD also try to update inventory. I really dont know how to fix it. Are you really worried about this error? I think it's okay if, player will be kicked, if he try to use a hacked client to create cheat item.

JoeSGT commented 6 years ago

Yea i guess it's okay hm i was just scared of normal players who might have the abilities to edit there own items using give command or something being kicked

Leymooo commented 6 years ago

i think they will not be kicked if they use give command. Maybe if they are in creative mode, they will be kick.

JoeSGT commented 6 years ago

Sorry but there are some players without an hacked client getting kicked by this without having the give command