Leymooo / ItemFixer

Избавь свой сервер от читерских предметов!
http://rubukkit.org/threads/119485/
4 stars 8 forks source link

Potion issue #2

Closed ghost closed 7 years ago

ghost commented 7 years ago

The plugin is still removing OP potions , and is pretty annoying for allowed servers.

i already deleted the custonPotionEffect filtering...

Leymooo commented 7 years ago

Are you sure that it is ItemFixer? Maybe you have ProtocolSupport or ViaVersion?

ghost commented 7 years ago

yep, i have both, without itemfixer is allowing them

Leymooo commented 7 years ago

What is your spigot/cb version? I will check it later.

ghost commented 7 years ago

1.10.x @Dimatert9 If you have skype ill will be glad if you help me to find the issue. im planning to import the source into the main code of my plugin, but it needs first to get rid of that potion filtering

Leymooo commented 7 years ago

I have skype. But my English is not good, because my main language is Russian.

Leymooo commented 7 years ago

I cannot reproduce this on 1.10.2 with ItemFixer and ProtocolLib installed. https://youtu.be/7kRbDFcbp9M

ghost commented 7 years ago

You did, it replaces the potion with uncraftable and it still work, but is annoying when the potions have a custom name

Leymooo commented 7 years ago

It is spigot change name. Not itemfixer

ghost commented 7 years ago

how to fix it?

when i disable itemfix the potion name doesn't not change

EDIT: is itemfix, because if i check the potion NBT is not working

Leymooo commented 7 years ago

it is not itemfixer.

ghost commented 7 years ago

@Dimatert9 did you tried to look into item's NBT?

because the potion effects get removed...

and in my server the NBT: in config is empty.

try inspecting the item NBT after they get filtered.

Skillclient owns a hack for this. or else use a one forge mod, i think is named actuallyaddictions.

ghost commented 7 years ago

explain why on splash potion there's some black bubbles and those means no potion effects in those bubbles!

Leymooo commented 7 years ago

ItemFixer just remove 'CustomPotionEffects' tag from item. If you remove this tag from config, plugin will stop remove this tag. https://youtu.be/7kRbDFcbp9M Look at video: 0:58. Potion filter is enabled. In creative tab potion has 3 nbt tags. When I move this potion to slot bar, potion has 2 nbt tags. 01:13. Potion filter is disabled. In creative tab potion has 3 nbt tags. After move to slot bar - it has 3 nbt tags. 1:20. i throw this potion. and effect work.

ghost commented 7 years ago

WE DID, that wasnt working!

ghost commented 7 years ago

might you can give me your jar you are actual using?

Leymooo commented 7 years ago

I am using jar from spigotmc.

Leymooo commented 7 years ago

Can you check without ProtocolSupport or ViaVersion

ghost commented 7 years ago

I did, im using just protocollib

ghost commented 7 years ago

Without viaversion too

Leymooo commented 7 years ago

I am really dont know what wrong. https://youtu.be/di4jXGBBptk what i do wrong?

ghost commented 7 years ago

Mmh, check this version :

https://www.dropbox.com/s/ox7h4k494juclzf/ItemFixer.jar?dl=0

Leymooo commented 7 years ago

With this version a have no problem. You're definitely sure that it cause by ItemFixer?

ghost commented 7 years ago

is itemfixer.

Leymooo commented 7 years ago

Okey. Can you wtire again, what problem you have?

ghost commented 7 years ago

i said it, when you get a potion without the CustonPotionEffect: in config it still removes it and make the potion name as uncraftable potion...

Leymooo commented 7 years ago

Its spigot change name to uncraftable potion. Are sure that potion effects will remove? https://youtu.be/di4jXGBBptk At 1:59 you can see that, after remove potion effect i cant use item or add new items to slot bar. If you get potion and can add new items to slot bar, it mean that it isnt ItemFixer.

ghost commented 7 years ago

yeah, it does. stop asking the same question...

Forgot: my plugin wont own a permission manager.

Leymooo commented 7 years ago

How i can help you, If I have no problems. Maybe you can make a video?

ghost commented 7 years ago

@Dimatert9 well, maybe teamviewer?

Leymooo commented 7 years ago

let's go.

Leymooo commented 7 years ago

I can close this issue?

ghost commented 7 years ago

DONT, i found is itemfixer as i put it back the item got wiped!

ghost commented 7 years ago

DONT, i found is itemfixer as i put it back the item got renamed againnn!

@Dimatert9

Leymooo commented 7 years ago

I think it is not ItemFixer and not Spigot. Because in single player it also change to uncraftable potion.

Leymooo commented 7 years ago

Try give potion from console give @a potion 1 373 {CustomPotionEffects:[{Id:1,Amplifier:0,Duration:600},{Id:3,Amplifier:0,Duration:600},{Id:5,Amplifier:0,Duration:600},{Id:6,Amplifier:0,Duration:600},{Id:8,Amplifier:0,Duration:600},{Id:10,Amplifier:0,Duration:600},{Id:11,Amplifier:0,Duration:600},{Id:12,Amplifier:0,Duration:600},{Id:13,Amplifier:0,Duration:600},{Id:14,Amplifier:0,Duration:600},{Id:16,Amplifier:0,Duration:600},{Id:21,Amplifier:0,Duration:600},{Id:22,Amplifier:0,Duration:600},{Id:23,Amplifier:0,Duration:600}],display:{Name:"Lucky Potion",Lore:["Nothing to explain once used."]}} image

ghost commented 7 years ago

Close this, is solved. there is a new issue.