Lgmrszd / CompressedCreativity

Bridging Create and PneumaticCraft: Repressurized together
MIT License
6 stars 7 forks source link

Crashes clients on 1.19.2 when joining server #33

Closed Nycto97 closed 11 months ago

Nycto97 commented 12 months ago

I'll leave the log here. Also, I use /flywheel backend off, I don't know if this causes any issues with your mod.

https://bytebin.lucko.me/HAfMfj2BMX

It says Suspected Mods: Forge (forge), Minecraft (minecraft), Compressed Creativity (compressedcreativity), Create (create), Dungeons Libraries (dungeons_libraries)

Lgmrszd commented 11 months ago

The log seems to be gone, can you reupload it?

Lgmrszd commented 11 months ago

Alright, I was able to reproduce this bug. The reason it happens is because when I attach pneumatic capability to the backtank, it checks it's enchantment level (to get capacity), but Dungeon Libraries changes it in a way that checking item for enchantments also checks for capabilities (getTagEnchantmentLevel in EnchantmentHelper.

I think I managed to fix it in the upcoming 0.1.8 update, and if it still breaks you should be able to disable pneumatic capability of a backtank with backtank_compat_item in Compressed Creativity config (due an oversight in my mod that won't work on current version)

Lgmrszd commented 11 months ago

Fixed in https://github.com/Lgmrszd/CompressedCreativity/commit/aaeeb7eb8d32d67cca643a6e42da36bb680720bd