search

Li-Lehao / pe

0 stars 0 forks source link

Overzealous input validation #3

Open Li-Lehao opened 2 years ago

Li-Lehao commented 2 years ago

steps to reproduce: type the command add n/testing2 p/+65 98765432 e/j@example.com g/4.50 i/NTU c/Computer Science y/06/2025 j/Software Engineer into the text box and press enter.

Expected: This phone number should not be blocked.

Actual: The error message says the phone number should only contain digits

screenshots:

image.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Use of Hyphen, Apostrophe, and Special Letters in name

On entering add n/D-souza p/123 e/a@a.com g/4.50 i/NTU c/Computer Science y/06/2025 j/Software Engineer a/INTERVIEWED, the Application addition is rejected. Hyphens, Apostrophe and Special Letters are not allowed in names.

This is an issue as some people's names, especially in western countries, contain these characters, (e.g. Mary-Anne, De'souza).

Actual: image.png

[original: nus-cs2103-AY2122S1/pe-interim#4566] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Status:
Accepted

Response:
We acknowledge that some of of field's input validations is over-zealous. However, the majority of inputs are valid within our input validation and therefore, severity should be low in our group's opinion. All field validations are decided as a group and we feel that it is a good enough compromise between overbearing and lax.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]