Open Li-Lehao opened 2 years ago
Status:
Rejected
Reason:
It is an expected and documented behaviour as view/find commands do not warrant to be undoed as it does not affect the data in InternWatcher
Team chose [response.Rejected
]
Reason for disagreement: Thanks for your reply.
I know that some commands such as find
and findTags
cannot be undone and redone according to your design.
I think this design in which only some of the commands can be undone is not very reasonable.
1, users need to remember which commands can be undone and which are not.
2, the user may not know which command will be undone when he use the undo
command. (The user might think that the software will undo his last command, however, maybe the last command is not undoable, and the software will find the nearest undoable command to undo.)
3, suppose the user add
a person, then find someKeyword
to enter a filtered list, and then use undo
. The software will undo the add
command by removing that added person from the list. However, the filtered list is not refreshed and the user is still viewing the result of find
. This is because when implementing the undo model, the dev team did not record the predicate
in each state
. I think this design might make the user have a higher risk of losing their data (since the undone command is not that one he intended to undo and he cannot see the result).
Therefore, I think that this can still be considered a feature flaw, and the severity is low.
Steps to reproduce: add a person to the list. type command
find Alex
and the filtered list will show person Alex only. type commandundo
into the text box and press enter.Expected: The software should undo the list command and go back to the list with all persons. Or the software undo the add command and refresh the list.
Actual: the software undo the add command, but the filtered list is not updated, it only shows Alex, which is the result of
find Alex
Screenshots: