LiHaixin000 / pe

0 stars 0 forks source link

Person with the same name should be added #6

Open LiHaixin000 opened 4 days ago

LiHaixin000 commented 4 days ago

If two users have the same name, David Li, they have different numbers and addresses. The addressbook does not allow me to add both of them. Step to reproduce: add n/David Li p/99999999 e/davidli@example.com a/David street, block 321, #01-01 x/123

Screenshot 2024-11-15 at 16.33.46.png

nus-pe-bot commented 15 hours ago

Team's Response

Duplicate of Issue #195.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add person of the same name, even with different email address, and phone number, as specified in the user guide.

Description:

The user guide mention that "We allow Users to create person of the same Name, Email Address and Phone Number, as long as not all details are the same." However, this is not true in the application, as I have a person with different email address, and phone number, (though with same name), but the add command doesn't work.

Steps to reproduce:

Apply the following two command sequentially:

add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01

add n/John Doe p/98765321 e/johnd@exampl.com a/John street, block 123, #01-02

Expected Result:

The last command should pass without errors.

Actual Result:

The last command fails with error, "This person already exists in the address book".

Screenshots:

image.png


[original: nus-cs2103-AY2425S1/pe-interim#277] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for noticing the issue with the 'add' command! When implementing the changes to the AB3 'add' command we were negligent to updating the correct usage of the 'add' command on the UG which shows that we do not allow duplicate names and allows duplicate usage of the other fields.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]