search

LiUGraphQL / LinGBM-OptimizationTechniquesExperiments

Artifacts of LinGBM-based experiments to compare optimization techniques for GraphQL server implementations
0 stars 0 forks source link

Super bug in undergraduateDegreeObtainedBystudent of cache server #2

Closed hartig closed 4 years ago

hartig commented 4 years ago

In addition to all the problems described in #1, the resolver for undergraduateDegreeObtainedBystudent in the cache-variation of the test server has another, even worse problem: The if-block for the filter condition creates a new variable called students by using the keyword let (see line 272), which makes this new variable not visible outside of this block!!! Consequently, after doing all of the filtering, the resolver completely ignores what it just did and, instead, returns the unfiltered list of grad students (see line 310)!!!!

Argh!!!

chengsijin0817 commented 4 years ago

This issue is fixed in the latest commit (7fedcf7).

hartig commented 4 years ago

Thanks!