search

LiUSemWeb / HeFQUIN

HeFQUIN is a query federation engine for heterogeneous federations of graph data sources, including federations of knowledge graphs.
https://liusemweb.github.io/HeFQUIN/
Apache License 2.0
19 stars 3 forks source link

Reduce number of vocabulary rewriting #294

Closed chengsijin0817 closed 1 year ago

chengsijin0817 commented 1 year ago

Implement a plan optimizer that determines join ordering by considering vocabulary mapping and cardinality. Reduce the number of vocabulary rewriting by eliminating some l2g and g2l when the same vocabulary mapping is used.

hartig commented 1 year ago

@chengsijin0817 What is the status of this PR? I see that the last thing that happened to it is that you added some commits, but since you didn't explicitly request my review again, I was assuming that you are not done yet with addressing my previous review. Are you?

chengsijin0817 commented 1 year ago

@chengsijin0817 What is the status of this PR? I see that the last thing that happened to it is that you added some commits, but since you didn't explicitly request my review again, I was assuming that you are not done yet with addressing my previous review. Are you?

Hi @hartig, I think this branch (implementation of a physical plan optimizer) was discarded after we created a join order optimizer for logical plans (i.e., CardinalityBasedJoinOrderingWithRequests) and implemented different vocabulary-related rewriting rules as separate heuristics that can be applied in LogicalOptimizerImpl. The related heuristics are: RemoveUnnecessaryL2gAndG2l PullUpLtgOverUnion PullUpLtgOverJoin PushJoinUnderUnionWithRequests RemovePairsOfG2lAndL2g

hartig commented 1 year ago

I think this branch (implementation of a physical plan optimizer) was discarded after ...

In other words, it can be safely removed? Please confirm again and I will remove it.

chengsijin0817 commented 1 year ago

I think this branch (implementation of a physical plan optimizer) was discarded after ...

In other words, it can be safely removed? Please confirm again and I will remove it.

Yes, I confirm that this branch can be safely removed. Thanks.

hartig commented 1 year ago

Thanks for the confirmation. I am closing this PR and removing its branch now.