search

LiUSemWeb / HeFQUIN

HeFQUIN is a query federation engine for heterogeneous federations of graph data sources, including federations of knowledge graphs.
https://liusemweb.github.io/HeFQUIN/
Apache License 2.0
19 stars 3 forks source link

WIP: Converts vocabularies to OWL ontologies #362

Closed hartig closed 2 months ago

hartig commented 2 months ago

Closes #361

hartig commented 2 months ago

@keski Related to my last point in https://github.com/LiUSemWeb/HeFQUIN/issues/348#issuecomment-2371030129, it is not clear to me why we need to copies of these files in the ./hefquin-vocabs/ directory. And since you made an actual copy, I don't see what exactly has been changed in comparison to the original versions. If your intention is to replace the old versions of these two files by the new versions, with the new names, then please do it using git mv.

keski commented 2 months ago

The only difference between the files is the addition of the triples that state that the vocabularies are OWL ontologies:

<http://w3id.org/hefquin/engineconf> rdf:type owl:Ontology ;
...
<http://w3id.org/hefquin/lpg2rdf> rdf:type owl:Ontology ;
...
hartig commented 2 months ago

... and the renaming of the namespace, and the change from rdfs:Class to owl:Class, right? (as I understood from your earlier comments somewhere else)

keski commented 2 months ago

... and the renaming of the namespace, and the change from rdfs:Class to owl:Class, right? (as I understood from your earlier comments somewhere else)

Yes, that's right.

With the latest commits, I've now also propagated the updated namespace into the actual code base.

keski commented 2 months ago

Darn, forgot to use git mv... I'll see if I can fix that!

keski commented 2 months ago

There, now the history of the vocabularies show that they have been renamed (git mv).

hartig commented 2 months ago

Perfect! Anything left in this PR?

hartig commented 2 months ago

Okay. I have run the build.sh script locally and everything works as expected.

I will merge the PR now.