Liam0102 / Star-Wars-Vehicles

Star Wars Vehicles addon for Garrys Mod (Code only)
3 stars 2 forks source link

Update #14 #7

Closed Servius closed 7 years ago

Servius commented 7 years ago
Servius commented 7 years ago

@Liam0102

Liam0102 commented 7 years ago

Why are you moving files into "addon specific"?

Servius commented 7 years ago

Thou

Servius commented 7 years ago

On my phone. Accidntal close on my end.

Thought it would be easier to navigate the repository if moved the addon stuff like the json, .txt, lua files, and mats away from any potential files that we wouldnt want accidentally uploaded to the live addon.

Servius commented 7 years ago

Like the readme and template.

Liam0102 commented 7 years ago

Not necessary, not to mention the template shouldn't be included in this GIT. This specifically for the development of the Episode 1. The template can be linked to, but shouldn't be included.

Image files are fine (All though I doubt the HUD elements need work), and honestly a Readme with one line in it isn't really worth it.

Servius commented 7 years ago

Was just thinking of convience regarding the template. Wouldnt it be a bit silly to have a whole new repo created just for one file.

I intend to update the readme later but adding it now will give syph, doc, randoms, and yourself the option to update it with relavent information in the mean time.

Servius commented 7 years ago

But you are right. This isnt exactly the most amazing update ever. Just setting groundwork for stuff thatll help later down the road.

Liam0102 commented 7 years ago

The template doesn't need to be hosted here. I already have it on my dropbox, it can just be linked to. I'm going to close this, but if you want to open a new one with just the image files and the readme that's up to you.

Servius commented 7 years ago

Could have just just

Servius commented 7 years ago

Iphones charging are annoying af.

Anyways, Id like to be able to add more information (like the commenting and formatting i added to the few sections i was able to do in the time i had available tonight) so others (or myself when i cant remember how to do something) have an easier time adding more advanced functionality not currently documented (like seats or first person view overlays) elsewhere.

I believe you could have split the pull request and only accept the portions you were okay with