error: missing attribute 'can_id'

[Addy771]

Background:

• I've got a logging script that I'm updating to work with the current version of pyvesc.
• I pulled pyvesc as a folder within my logger repo, since PyPI still has an old version of pyvesc.

When I try to encode a GetValues request, I get an exception:

type object 'GetValues' has no attribute 'can_id'
Traceback (most recent call last):
  File "logger.py", line 102, in log_vesc
    send_packet = pyvesc.encode_request(GetValues)
  File "./pyvesc\pyvesc\protocol\interface.py", line 51, in encode_request
    msg_payload = pyvesc.protocol.base.VESCMessage.pack(msg_cls, header_only=True)
  File "./pyvesc\pyvesc\protocol\base.py", line 104, in pack
    if instance.can_id is not None:
AttributeError: type object 'GetValues' has no attribute 'can_id'

I was able to avoid this error by modifying VESCMessage in protocol\base.py. I added this line to the VESCMessage constructor: cls.can_id = None

With that change, pyvesc is working and I get correct data with GetValues.

[LiamBindle]

@Addy771 Thanks for opening an issue. Could you make a PR with your fix? That way I can share it with other users.

Thanks! -Liam

[Addy771]

I tried to, but I think I can't, due to the way that I pulled and merged pyvesc.

Here's the commit where I made this fix: https://github.com/Addy771/VESC-logger/commit/c103f6eb220ea13cee3a49bc7514d0afa06ecafc

Maybe you could just make the change and reference this issue.

[LiamBindle]

Sounds good, I can add this.