search

LiamMorrow / LiftLog

A cross platform app for tracking your lifts in the gym
https://liftlog.online
GNU Affero General Public License v3.0
70 stars 8 forks source link

Save/Update/Finish Button hidden by status bar #156

Open corayana opened 6 months ago

corayana commented 6 months ago

Hi, I just started using your app and am pretty happy so far. One issue that bothers me is that the app reaches under the status bar on my phone (Google Pixel 4a). This makes it very difficult to save/update or finish a session. I would bei very happy you could fix this.

Screenshot_20240509-140845

LiamMorrow commented 6 months ago

Thanks for the report! It definitely shouldn't be doing that, I'll see what I can do

LiamMorrow commented 6 months ago

Would you be able to tell me your android version please? You can find it by going into your phone's settings, scrolling to "System" then tapping "About Phone"

Thank you!

corayana commented 6 months ago

Thank you for the quick response. My android version is 13.

LiamMorrow commented 6 months ago

Fantastic. I'll have a play with the emulator tonight to see what I can do.

LiamMorrow commented 6 months ago

I cannot for the life of me get this bug to show up I'm afraid. I have a workaround, which would just amount to offsetting the top by a static distance. I'll release a new version with this toggle which should help you in the meantime.

corayana commented 5 months ago

Thank you very much for your efforts! Unfortunately, I have no idea what the problem might be. Anyway, the workaround works so far, at least for ending a session (but not for creating/editing a new/existing session)

LiamMorrow commented 5 months ago

Yeah it's a headscratcher. You say it doesn't work for creating/editing sessions. Could you show me a screenshot of what you mean? It should apply everywhere

LiamMorrow commented 5 months ago

Also, do you have developer mode enabled? If so, would you be able to show your WebView implementation? I wonder if it's a browser version issue...

LiamMorrow commented 1 month ago

https://github.com/LiamMorrow/LiftLog/blob/30b2530d4ec5d1bc321dd7f5c07ab34b1a29411f/LiftLog.Maui/Platforms/Android/MainActivity.cs#L55

This is where I perform the calculation to get the insets. It works on all emulators and my phone (asus zenfone 9).