search

LiamMorrow / LiftLog

A cross platform app for tracking your lifts in the gym
https://liftlog.online
GNU Affero General Public License v3.0
74 stars 8 forks source link

tap to reveal overflown exercise name #241

Open LiamMorrow opened 3 months ago

LiamMorrow commented 3 months ago

Exercise names can overflow and be truncated with an elipsis... Tapping them should reveal them somehow. Thinking either tooltip, or potentially scrolling like a music player?

cannontrodder commented 1 month ago

My issue with the overflow is it hides the history icon which I find crucial for making decisions on tweaking things!

LiamMorrow commented 1 month ago

Thanks for letting me know! It definitely shouldn't be doing that, and I can't reproduce it. 🤔 Are you on iphone or android?

The history button does hide itself when you have never done that exercise before (exact same amount of sets / reps/ exact name). Is is possible this is the cause of it hiding? I've been moving to a more loose model, so I think I could start showing it all the time.

I've since merged: https://github.com/LiamMorrow/LiftLog/pull/280

This will show history even if the number of reps/sets is different.

cannontrodder commented 1 month ago

This is almost certainly to because I edited the exercise (added a set)!

LiamMorrow commented 1 month ago

That's good to know :) That change to show other anything with the same name in the previous view is now live on Android (having trouble with iOS builds rn)