LiamMorrow / OrgnalR

SignalR backplane implemented through Orleans
Apache License 2.0
34 stars 7 forks source link

Use own classes for serialization #10

Closed LiamMorrow closed 4 years ago

LiamMorrow commented 4 years ago

We replace usage of the signalr class: InvocationMessage, with our own MethodMessage. This has the same properties (of the ones we use), however since it is built into our library, Orleans can generate a proper serializer for it at compile time, and future proofs us against internal changes to that class.

Investigation sparked from an issue where messages were failing to deserialize due to an invalid buffer in dotnet core 3.1. It seemed related to a semi recent change in serilization from the core orleans library.