search

LiamMorrow / OrgnalR

SignalR backplane implemented through Orleans
Apache License 2.0
35 stars 8 forks source link

[BUG] Can't add OrgnalR Nuget package to Service Fabric service (stateless, ASP.NET Core web application) #13

Closed danvanderboom closed 3 years ago

danvanderboom commented 3 years ago

Describe the bug Nuget package installation fails and rolls back. There's a conflict with this package which is used by the generated code for a new project: Microsoft.ServiceFabric.AspNetCore.Kestrel.

To Reproduce Steps to reproduce the behavior:

  1. Create a new Service Fabric Application in Visual Studio.
  2. From the cluster project (orange icon): right click, Add, "New Service Fabric Service...".
  3. Select "Stateless ASP.NET Core", provide a name "Test.SignalR", and hit the Create button.
  4. Attempt to add the SignalR.Orleans Nuget package to the new ASP.NET Core service project.

Expected behavior The Nuget package is added and can be used.

LiamMorrow commented 3 years ago

Thanks for the bug report @danvanderboom. Very interesting. I'll have a dig tonight to see what the issue is. Hopefully can push out a version that's compatible

LiamMorrow commented 3 years ago

I am able to reproduce... This isn't the first time I've run into issues with this System.Text.Encoding package (not in OrgnalR but professionally). Will keep you in the loop

LiamMorrow commented 3 years ago

So. I thought it might be that I should be targeting netcoreapp3.1 and netstandard2.0, however this did not solve the issue.

I then went and installed Microsoft.AspNetCore.SignalR.Core - Worked Installed Microsoft.Orleans.Runtime.Abstractions - Failed

Tried both combinations. So it seems like an issue when Microsoft.ServiceFabric.AspNetCore.Kestrel is installed with BOTH of those packages.

To be honest, I think the Microsoft.AspNetCore.SignalR.Core package is overdue for an update (if only to fix issues like this). It hasn't been updated since 2018. I'm gonna try and deploy a version which fixes the conflicts, but I have a feeling it won't be solvable in OrgnalR, and in your application you will need to go through and install each conflicting package explicitly

LiamMorrow commented 3 years ago

Hey @danvanderboom So I ended up getting it going in the end. Version 1.4.1 installs correctly for my application.

I'm gonna close this one out, feel free to reopen if it continues to fail for you 👍