search

LiamMorrow / OrgnalR

SignalR backplane implemented through Orleans
Apache License 2.0
35 stars 8 forks source link

[FEATURE] Engage with Orleans Discord channel in show-and-tell #36

Open bbehrens opened 1 year ago

bbehrens commented 1 year ago

Microsoft had previously blessed the SignalR.Orleans backplane as an official backplane for SignalR. https://learn.microsoft.com/en-us/aspnet/core/signalr/scale?view=aspnetcore-7.0#third-party-signalr-backplane-providers I was thinking it might be a good idea to try and engage with the very active Discord community for Orleans https://discord.gg/vByufzUJ and find out what all might be required for this project to get the same. There's some obvious low hanging fruit like documentation and testing but wanted to ask first and see if that was a direction you'd be interested in the project going. To my knowledge it's the only functioning Orleans 7 backplane and has the benefit of not requiring Streams. Potentially even more attractive now that streams has been split off into a separate nuget and the underlying tech they used (SimpleMessageStreams) replaced with Broadcast channel. The SignalR.Orleans team has been completely unresponsive to discussions about upgrading to Orleans 7 and I've gotten no traction in the Discord channel about it either.

LiamMorrow commented 1 year ago

That would be great! Yeah documentation and testing are the big issues I'd say.

There's basically no test coverage of a lot of the lib, and it would be good to get an end to end test suite going. The big one I'd like to do is a load test at various orgnalr message buffer lengths.

Yeah the streams were a big reason I had to write this, every now and then they would just hang indefinitely and messages would stop receiving.

LiamMorrow commented 1 year ago

So making ground on a better example here: https://github.com/LiamMorrow/OrgnalR/pull/37/files

It utilizes a couple of the key features which OrgnalR facilitates, and should hopefully work out of the box for people.

bradygaster commented 1 year ago

Very interested in some of the deadlock issues you mentioned in the README. Have those been submitted to the main Orleans repo? If not, can we work to get those in?

LiamMorrow commented 1 year ago

Hmm, I'm sorry it's been a couple years and I don't remember. I believe I posted in an existing issue that was marked as complete, but still had the issues. I'll see if I can roll back the project that was having issues to a version where we were using the SignalR.Orleans package to repro.

I remember trying a couple of different stream providers, both in memory, and persistent. A couple messages might work, then it got stuck in an Orleans method.

At any rate, I'll see how I go with pulling up the old version and running in the next couple days