LiamsGitHub / AS7265x-spectrometer

Python module to drive the SparkFun Triad Spectroscopy Sensor
16 stars 13 forks source link

Is the order of calibrated values correct? #1

Open cipri-tom opened 5 years ago

cipri-tom commented 5 years ago

Hi,

Thank you so much for doing the heavy lifting for this complicated device! I was trying to use it for some measurements and I'm getting some values that I am not sure make sense. Therefore, I would like to double check with you that the order of calibrated values is correct.

Here is why I think there is a problem. Reading the CAL values is done in the order of the devices, as indicated by this line: https://github.com/LiamsGitHub/AS7265x-spectrometer/blob/9b0ce11be6b904a89e907dc18dd10b03620cc90f/spectrometer.py#L354

and then, in the order of the registers. Following the datasheet and your very useful schema of it at the beginning of the Repository, the above order would give:

R S T U V W   G H I J K L   A B C D E F
--AS72651--   --AS72652--   --AS72653--

Then, in the reordering function, the mappings are like so: https://github.com/LiamsGitHub/AS7265x-spectrometer/blob/9b0ce11be6b904a89e907dc18dd10b03620cc90f/spectrometer.py#L140

>>> print(' '.join(reorderData('R S T U V W G H I J K L A B C D E F'.split())))
R S T U V W G H A I B J C D E F K L

And this is different from the desired order of A B C D E F G H R I S J T U V W K L

I hope I missed something, but if not, it's not a big problem, I'll just have to reoder the reading I have already saved.

Many thanks, again, for your implementation!