ErrorDecoderInterceptor 不支持接口继承的 RetrofitClient

LianjiaTech / retrofit-spring-boot-starter

A spring-boot starter for retrofit, supports rapid integration and feature enhancements.（适用于retrofit的spring-boot-starter，支持快速集成和功能增强）

Apache License 2.0

1.78k stars 340 forks source link

ErrorDecoderInterceptor 不支持接口继承的 RetrofitClient #141

Open achievec opened 1 year ago

achievec commented 1 year ago

com.github.lianjiatech.retrofit.spring.boot.interceptor.ErrorDecoderInterceptor#intercept


@Override
@SneakyThrows
public Response intercept(Chain chain) throws IOException {
    Request request = chain.request();
    Method method = Objects.requireNonNull(request.tag(Invocation.class)).method();
    RetrofitClient retrofitClient =
            AnnotatedElementUtils.findMergedAnnotation(method.getDeclaringClass(), RetrofitClient.class); // 如果接口有继承关系，这里返回 null，导致 NPE
    ErrorDecoder errorDecoder =
            AppContextUtils.getBeanOrNew(applicationContext, retrofitClient.errorDecoder());

achievec commented 1 year ago

interface A{

@GET("/hello")
Object hello();

}

@RetrofitClient(baseUrl = "urlB")
interface B extends A{

}

@RetrofitClient(baseUrl = "urlC")
interface C extends A{

}

chentianming11 commented 1 year ago

这种情况，目前是不支持的，此时拿不到retrofitClient。

根本原因是retrofit不支持，已经向Retrofit提过相关issue了，等待后续retrofit支持。

efemoney commented 1 year ago

See prior issue at #109 (which I think should've been left open)

chentianming11 commented 5 months ago

Versions 2.4.0 and 3.1.0 are already supported

efemoney commented 4 weeks ago

You should close this issue.