search

LiaraAlis / kimai2-SmallBusinessRuleBundle

This plugin provides the possibility to use the small business regulation, as it can be applied in Germany and Austria, when creating invoices in Kimai.
4 stars 1 forks source link

Invoice overview shows same sum values for different clients #5

Closed lwndp closed 1 year ago

lwndp commented 1 year ago

As initially outlined here: https://github.com/kevinpapst/kimai2/issues/3562

Issue resolved when deactivating the plugin entirely (not just the 'small business' option in settings

LiaraAlis commented 1 year ago

This is already fixed in v1.0.1. Please update.

lwndp commented 1 year ago

Awesome! Thank you!

LiaraAlis commented 1 year ago

Thank you for using my plugin. I appreciate any feedback. 😊

lwndp commented 1 year ago

The invoice preview, overview section (at the bottom), still doesn't seem to show correct projects and related total hours. Only the total sum is now correct per client. Can you confirm this on your end?

I think this issue should be opened again.

LiaraAlis commented 1 year ago

You're totally right, I didn't noticed that the listed projects doesn't match the customer. This is a very strange problem. I have a look on this.

LiaraAlis commented 1 year ago

@lwndp Can you please try to checkout the master branch and test my changes in commit https://github.com/LiaraAlis/kimai2-SmallBusinessRuleBundle/commit/c36368305b02dcd526b4ae89e4502b3407770982? I hope that these changes fixes the problem. To be honest, I have not yet really understood the cause of this issue…

If everything works well, I will release a new version.

lwndp commented 1 year ago

@LiaraAlis your fix seems to have resolved the issue. Only thing I'd like to note is that the directory containing your plugin is called kimai2-SmallBusinessBundle and thus doesn't load into the kimai cache. I guess there is some sort of name validation going on. I had to rename it to "SmallBusinessBundle" for it to show up / work.

LiaraAlis commented 1 year ago

@lwndp This is because this repository is named "kimai2-SmallBusinessRuleBundle". Because of that, you have to specify the target directory when using git clone. See here: https://github.com/LiaraAlis/kimai2-SmallBusinessRuleBundle#installation

LiaraAlis commented 1 year ago

Released v1.0.2: https://github.com/LiaraAlis/kimai2-SmallBusinessRuleBundle/releases/tag/v1.0.2

lwndp commented 1 year ago

My bad, sorry for not reading all the was to the right 😅 Thanks for the quick response and fix 🙏