LibCity / Bigscity-LibCity

LibCity: An Open Library for Urban Spatial-temporal Data Mining
https://libcity.ai/
Apache License 2.0
889 stars 163 forks source link

Why do geographical embedding and semantical embedding share the GCN parameters in GEML? #322

Closed Ao-Last closed 1 year ago

Ao-Last commented 1 year ago

According to the paper, geographical embedding and semantical embedding are trained through two sperate networks. But ge and se are generated using the same GCN module in your implementation libcity/model/traffic_od_prediction Snipaste_2022-12-04_20-47-49

aptx1231 commented 1 year ago

@l782993610

Apolsus commented 1 year ago

You are right, thank you. It's fixed in pr #323