search

LibVNC / libvncserver

LibVNCServer/LibVNCClient are cross-platform C libraries that allow you to easily implement VNC server or client functionality in your program.
GNU General Public License v2.0
1.1k stars 482 forks source link

Explicitely including avcodec.h #520

Closed antenore closed 2 years ago

antenore commented 2 years ago

Build fails with the master branch of FFmpeg with these kinds of errors:

../client_examples/vnc2mpg.c:55:5: error: unknown type name ‘AVCodecContext’
     AVCodecContext *enc;
     ^~~~~~~~~~~~~~

This patch adds libavcodec/avcodec.h in vnc2mpg.c

bk138 commented 2 years ago

Thanks! Is the header available in older ffmpeg versions as well?

antenore commented 2 years ago

@bk138 the first commit is dated Sun Jul 22 14:18:56 2001 +0000

Therefore, since FFmpeg n0.8, it should cover all possible LibVNC use cases and beyond

antenore commented 2 years ago

After this PR I'll ask a rebase to the owners of the opened PR, test (when possible) and review the code, one by one. Those not answering, if it's worth doing it, I can try to take the ownership of the PRs. The others, if any, I think can be closed.

I'll prioritize the order of the PRs based on my feelings, but if you have any particular wish let me know.

As a side note, even if you probably already know this, I'm far from being a good developer, I'm just someone that try to get things done. ;-)

bk138 commented 2 years ago

As a side note, even if you probably already know this, I'm far from being a good developer, I'm just someone that try to get things done. ;-)

You know, it's the junior devs who regularly overestimate themselves and call themselves "good developer". To me, it's a sign of a seasoned developer to admit that there's always something to learn and improve :-)

bk138 commented 2 years ago

After this PR I'll ask a rebase to the owners of the opened PR, test (when possible) and review the code, one by one. Those not answering, if it's worth doing it, I can try to take the ownership of the PRs. The others, if any, I think can be closed.

I'll prioritize the order of the PRs based on my feelings, but if you have any particular wish let me know.

I'll leave some comments in the open PRs.