search

LibVNC / libvncserver

LibVNCServer/LibVNCClient are cross-platform C libraries that allow you to easily implement VNC server or client functionality in your program.
GNU General Public License v2.0
1.08k stars 483 forks source link

fuzz: adds one first fuzz target #541

Closed catenacyber closed 1 year ago

catenacyber commented 1 year ago

cc @bk138 cf https://github.com/google/oss-fuzz/pull/5137 for oss-fuzz integration

bk138 commented 1 year ago

@catenacyber sorry for the delay, the holidays sucked up most of my time. Thanks for starting this contribution and keeping up with it, I have one small request and then we're good to merge. Again, sorry for not being more responsive.

catenacyber commented 1 year ago

@bk138 just moved the fuzzing in the right section...

bk138 commented 1 year ago

@catenacyber Thanks for the swift reply and re-work! Now looking forward to https://github.com/google/oss-fuzz/pull/5137

bk138 commented 1 year ago

@catenacyber now that https://github.com/google/oss-fuzz/pull/5137 is in, how can this be employed for the CI?

catenacyber commented 1 year ago

I suggest we wait a few days to see if it works fine, then you can do https://google.github.io/oss-fuzz/getting-started/continuous-integration/ For example like https://github.com/OISF/libhtp/pull/374

catenacyber commented 1 year ago

@bk138 did you get the first oss-fuzz report ? do you have questions about it ?

bk138 commented 1 year ago

@bk138 did you get the first oss-fuzz report ? do you have questions about it ?

Yes and yes ;-)

catenacyber commented 1 year ago
  • Does this already run periodically on Google's side?

It runs continuously, once you get your account, you can see stats...

  • If so, with which branches?

The default branch cf Dockerfile in oss-fuzz https://github.com/google/oss-fuzz/pull/5137/files#diff-410c165083a4cedf476b93362d2107f8461532a1ae873020a2f541ff075432eeR19 : git clone --depth 1 https://github.com/LibVNC/libvncserver.git

  • It seems the reports are tied to a Google account. Can this be changed to info at christianbeier.net?

Doing at https://github.com/google/oss-fuzz/pull/9451

Yes, but maybe still wait some days before doing so...

catenacyber commented 1 year ago

@bk138 Did you get the access to the oss-fuzz report ? Do you have more questions about it ?

bk138 commented 1 year ago

@bk138 Did you get the access to the oss-fuzz report ? Do you have more questions about it ?

Yeah I did, but only to https://oss-fuzz.com/testcase-detail/5401990853427200, for the issue at https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=55190 I wrote an email to you.