search

LibVNC / libvncserver

LibVNCServer/LibVNCClient are cross-platform C libraries that allow you to easily implement VNC server or client functionality in your program.
GNU General Public License v2.0
1.11k stars 484 forks source link

libvncclient: improve compatibility with GnuTLS 3.8 #630

Closed yan12125 closed 2 weeks ago

yan12125 commented 2 weeks ago

Since GnuTLS 3.8, TTLS-SRP is disabled by default at compile time [1]. As a result, connecting to a server via TLS fails with:

Warning: Failed to set TLS priority: The request is invalid. (+SRP).

TLS handshake failed: No or insufficient priorities were set.

On the other hand, TLS-SRP is apparently unused in libvncclient. It seems TLS-SRP requires providing serveral parameters, including a username and a password, via specific GnuTLS API [2], which I didn't find in the codebase.

[1] https://gitlab.com/gnutls/gnutls/-/merge_requests/1681 [2] https://www.gnutls.org/manual/html_node/Authentication-using-SRP.html

bk138 commented 2 weeks ago

Thanks!

yan12125 commented 2 weeks ago

Whoa, that's blazingly fast! Thank you very much.

bk138 commented 2 weeks ago

That was just a coincidence with me being online and the change being very small ;-)