Libbum / Wafer

Parallelized 3D FDTD Schrödinger Equation Solver
MIT License
21 stars 2 forks source link

Implement noisy float #52

Closed Libbum closed 6 years ago

Libbum commented 6 years ago
Libbum commented 6 years ago

This has probably got it done. A few things are still raw floats and it could probably be implemented a little cleaner.

codecov[bot] commented 6 years ago

Codecov Report

Merging #52 into master will increase coverage by 4.89%. The diff coverage is 32.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   19.55%   24.44%   +4.89%     
==========================================
  Files           7        7              
  Lines        1713     2802    +1089     
==========================================
+ Hits          335      685     +350     
- Misses       1378     2117     +739
Impacted Files Coverage Δ
src/main.rs 0.71% <ø> (-0.5%) :arrow_down:
src/config.rs 0% <0%> (ø) :arrow_up:
src/grid.rs 22.76% <23.33%> (+4.96%) :arrow_up:
src/output.rs 52.83% <48%> (+3.52%) :arrow_up:
src/input.rs 26.72% <64.76%> (+10.59%) :arrow_up:
src/potential.rs 20.96% <8.82%> (+5.57%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update beef056...0056197. Read the comment docs.

Libbum commented 6 years ago

I think merging is fine since it isn't all that different. Times? Don't seem to be an issue. Bugs? They're not reproducing in this branch?

Will keep #31 and #48 open and reinvestigate them with this setup.