search

Libbum / Wafer

Parallelized 3D FDTD Schrödinger Equation Solver
MIT License
21 stars 2 forks source link

Refactor to involve more traits #58

Open Libbum opened 6 years ago

Libbum commented 6 years ago

There's a heap of overhead complexity now that is causing major concerns. A large refactor is probably needed. Will start here by adding a heap of types and invoke self assigned operations rather than passing everything everywhere. May include some fixes for #48.

codecov[bot] commented 6 years ago

Codecov Report

Merging #58 into master will decrease coverage by 0.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   23.33%   23.32%   -0.02%     
==========================================
  Files           7        7              
  Lines        1821     1822       +1     
==========================================
  Hits          425      425              
- Misses       1396     1397       +1
Impacted Files Coverage Δ
src/output.rs 49.59% <0%> (-0.28%) :arrow_down:
src/potential.rs 15.81% <0%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update adb0d24...d23e2f0. Read the comment docs.