search

Libelium / waspmoteapi

Tested and stable Waspmote API repository
137 stars 129 forks source link

Add timeout functionality when sending command to prevent the function f... #6

Closed nickdademo closed 10 years ago

nickdademo commented 10 years ago

...rom hanging if the module does not reply.

Add additional overloaded sendATCommand() function which allows the user to specify the "read-wait" timeout and whether the command send will retry on a "read-wait" timeout. Signed-off-by: Nick D'Ademo nickdademo@gmail.com

nickdademo commented 10 years ago

STATUS UPDATE: As of API v009, this change has NOT been adopted.

However, this proposed change seems to be redundant/unneeded as the function ALREADY has a response receive check with a timeout:

API v008: while ((!serialAvailable(_socket)) && (timeout < 10)) { timeout++; delay(1000); }

API v009: while ((!serialAvailable(_socket)) && ((millis() - timeout) < 10000)) { delay(100); if (millis() < timeout) { timeout = millis(); } }

Therefore, this pull request will be closed.