search

LiberAI / NSpM

🤖 Neural SPARQL Machines for Knowledge Graph Question Answering.
http://aksw.org/Projects/NeuralSPARQLMachines
MIT License
223 stars 87 forks source link

Fixes in README.md #20

Closed panchbhai1969 closed 5 years ago

panchbhai1969 commented 5 years ago

It may seem trivial, but README.md files are the first point of information that a parson refers to when trying to understand a project, The repository's README.md is good, but i have found some error that need attention.

NUMLINES= $(echo awk '{ print $1}' | cat data/monument_300/data_300.sparql | wc -l) There shouldn't be any space after =, the line should be : NUMLINES=$(echo awk '{ print $1}' | cat data/monument_300/data_300.sparql | wc -l)

Other README.md related issues and suggestions brought up by users are #12 #14 #17

thisisshub commented 4 years ago

@panchbhai1969 I believe #14 still isn't solved or mentioned in the current README.md. Should I make a PR to assess the required changes?