Libera-Chat / sable

GNU Affero General Public License v3.0
84 stars 8 forks source link

Enable invites by default, and add access flags for +i channels #48

Closed progval closed 1 year ago

spb commented 1 year ago

I'm not convinced about this one - the current behaviour matches solanum (except for +g not being implemented) which I think is a more relevant behaviour reference than any of the servers that behave as this PR does.

progval commented 1 year ago

the current behaviour matches solanum

It doesn't. With the default config, even ops cannot invite.

spb commented 1 year ago

OK, the current intended behaviour modulo a silly bug caused by forgetting a set of flags - the point being that whether +i is currently set isn't a factor in deciding ability to invite.

progval commented 1 year ago

Since the "Remove invite access flags from no-ops by default" commit, this PR fixes the config bug (so it behaves like Solanum by default) and provides the option to configure Sable to allow invites by non-ops (so it can behave like other IRCds)

spb commented 1 year ago

Right, but the two sets of invite flags is additional complexity that I don't really see the benefit from - "invite only when the channel isn't invite only" doesn't seem like a useful permission to have given that most channels don't flip +i on and off multiple times a day. Mode +g is a more intuitive way to configure invite permissions IMO (and more familiar to existing Libera users).

progval commented 1 year ago

Ok, fair. I'll open another PR with only the config change