LibertyDSNP / eth-sdk-ts

TypeScript SDK for DSNP on Ethereum
Apache License 2.0
9 stars 1 forks source link

Features/update announcements to match spec 178933309 #106

Closed rosalinekarr closed 3 years ago

rosalinekarr commented 3 years ago

Problem

We've updated the announcement spec since the SDK announcement module was written, so now the SDK is out of sync with the spec. Specifically, we're missing createdAt on all announcements. #178933309

Solution

Added createdAt to all announcement types and updated tests accordingly

Change summary:

Steps to Verify:

  1. Call a create method from the announcements module
  2. Check that the resulting object has a createdAt field
rosalinekarr commented 3 years ago

looks good to me except for the duplicate createdAt's that github found 👍

Fixed