LibertyDSNP / eth-sdk-ts

TypeScript SDK for DSNP on Ethereum
Apache License 2.0
9 stars 1 forks source link

No longer using destructuring #117

Closed pfrank13 closed 3 years ago

pfrank13 commented 3 years ago

Now not using destructuring because of, what I can only assume, is "this" style issues. Basically a private member _writableState will be undefined. Using the object directly fixes that issue

Problem

using destructuring causes FileStreams to have undefined members. Pivotal issue

Solution

No longer use destructuring and call the WriteStream methods .write and .end directly

Double Checks:

Change summary:

No longer using destructuring when working with the WriteStream in the putStream callback flow

Steps to Verify:

A bit tough as I needed to consume the library in another app to make sure it worked.