LibertyDSNP / eth-sdk-ts

TypeScript SDK for DSNP on Ethereum
Apache License 2.0
9 stars 1 forks source link

dsnpBatchFilter does not require any provider or signer #123

Closed wilwade closed 3 years ago

wilwade commented 3 years ago

Problem

The announcements API has a single method to get the contract for batch and subscribe operations. This method requires a signer to connect. This is necessary for the batch operation. The subscription (specifically the dsnpBatchFilter) is read only, so should be capable of running with just a provider. #178901784

Solution

Used the interface instead of the contract to get the needed topic data.

Double Checks:

Change summary:

enddynayn commented 3 years ago

👍 beautiful