LibertyDSNP / eth-sdk-ts

TypeScript SDK for DSNP on Ethereum
Apache License 2.0
9 stars 1 forks source link

dsnp.createNewDSNPRegistration returning a URI instead of a Registration #176

Closed claireolmstead closed 2 years ago

claireolmstead commented 2 years ago

Steps to reproduce

When you call dsnp.createNewDSNPRegistration.

Expected behavior

You would expect to receive an object of type Registration.

Actual behavior

Instead, a URI is returned.

Any other comments?

I would like to receive a registration instead of a URI upon create registration becuase that data type is reflecive of what was just made. When we receive a URI we would have to call another function to get what we just created, which seems like an extra step, especially becuase the new registration is available to be returned in the SDK function.

wilwade commented 2 years ago

Fixed in #179