LibertyDSNP / eth-sdk-ts

TypeScript SDK for DSNP on Ethereum

Apache License 2.0

9 stars 1 forks source link

Bug/throwerror/179470225 #181

Closed waylandli closed 3 years ago

waylandli commented 3 years ago

Problem

https://www.pivotaltracker.com/n/projects/2436354/stories/179470225

Solution

Changed the regexp in the helper function isDSNPUserId to account for leading 0's in id.
Made else statement to throw error if invlaid

Change summary:

Added some test cases
the convertToDSNPUserId function has various checks to validate the value given