LibertyDSNP / parquetjs

Fully asynchronous, pure JavaScript implementation of the Parquet file format with additional features
MIT License
55 stars 25 forks source link

Generated test files should be written to /tmp and not the test directory #104

Open shannonwells opened 1 year ago

shannonwells commented 1 year ago

Problem

This behavior is from the original version that this repo forked from. It writes test files to the test directory and never cleans them up. There are test files already in test/test-files, which are also used by some tests. This can be confusing for debugging and actually did confuse me when trying to debug some test failures.

Secondly, the test named "reads parquet files via http" in test/reader.js depends upon the file generated by bloomFilterIntegration.ts and that is poor test practice.

Solution

Test code that reads generated files will have to be correctly distinguished from test code that opens test/test-files, and point to the files in /tmp.