Closed Javier-varez closed 2 years ago
I believe this fixes #12.
Hello! Thank you for your interest in LibertyOS, and thank you for your PR! I have an update that I plan on releasing tonight, but I plan on merging your PR when 0.14.1 is published.
Thanks, again!
I have a few questions:
Cargo.lock
file should ideally be kept up to date with the new versions of dependencies. Since you're building a kernel (a binary and not just a library crate) keeping track of the up-to-date Cargo.lock
file helps with reproducibility (to ensure everyone uses the same dependencies). If we don't commit this change, cargo will anyway update the lock file for every user and keep that as a local change, since the version in the Cargo.toml
for the x86
crate is not compatible (because of semver
) with the one in Cargo.lock
.rust-toolchain.toml
, which is the new format as you can see here. This allows you to specify in more detail the actual toolchain, components and targets.semver
). In practice, the change for the x86_64
version is not really making a difference, because this version was already in the Cargo.lock
file. So only the x86
crate has been actually updated. Looking at the git log differences between both releases the changes are pretty minimal, so should cause no problem at all:
Excellent work! Alright, I have another version that should release tonight, which will include a bunch of cool stuff (a completely rewritten vgabuff module, work on syscalls, some new modules for mathematics, etc.). When said version is published, I can resolve whatever conflicts there are in the PR.
I'm new to using git, so bear with me. :)
Thank you, and God bless!
I just rebased the changes on top of the main branch, so you don't need to resolve the merge conflict anymore :) Thanks!
I'll need to rebase once more soon. I am getting ready to release the biggest version yet. I'm almost finished writing a basic shell. :)
Please rebase this PR.
There have been some changes in Rust 1.59 to stabilize the asm feature that now require action from crate users. This PR resolves them